Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: add debounceTime to virtual scroll, expanded docs #9931

Closed
wants to merge 10 commits into from

Conversation

mikerodonnell89
Copy link
Member

@mikerodonnell89 mikerodonnell89 commented May 26, 2023

fixes #9238

Adds debounceTime to virtual scrolling to fix performance issues. Separates tree table into separate doc page and demonstrates use of expandedStateKey

@netlify
Copy link

netlify bot commented May 26, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 1e67097
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6478ab0183d66c00087b6b82
😎 Deploy Preview https://deploy-preview-9931--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 26, 2023

Visit the preview URL for this PR (updated for commit 1e67097):

https://fundamental-ngx-gh--pr9931-fix-virtual-scroll-d-mk2bmmmb.web.app

(expires Sun, 04 Jun 2023 14:41:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@mikerodonnell89 mikerodonnell89 changed the title wip: try adding debounceTime to virtual scroll fix(platform): add debounceTime to virtual scroll May 26, 2023
@mikerodonnell89 mikerodonnell89 changed the title fix(platform): add debounceTime to virtual scroll fix(platform): add debounceTime to virtual scroll, expanded docs May 26, 2023
@mikerodonnell89 mikerodonnell89 marked this pull request as ready for review May 26, 2023 20:59
@g-cheishvili g-cheishvili force-pushed the fix/virtual-scroll-debounceTime branch from 1a659e9 to 625a900 Compare May 29, 2023 12:54
Copy link
Contributor

@g-cheishvili g-cheishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure whether this will help with excessive amount of the rows, but it's a step into right direction

@mikerodonnell89 mikerodonnell89 changed the title fix(platform): add debounceTime to virtual scroll, expanded docs wip: add debounceTime to virtual scroll, expanded docs Jun 1, 2023
@mikerodonnell89
Copy link
Member Author

Closing because @fkolar is picking up this task

@g-cheishvili g-cheishvili deleted the fix/virtual-scroll-debounceTime branch November 14, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fdp-table][Sourcing][Dev Blocker] Tree table expandAll and collapseAll concerns and queries
3 participants